[SDK] Optimize ERC20 transferBatch #5256
Merged
+186
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f98059c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Contributor
size-limit report 📦
|
| } else { | ||
| amountWei = item.amountWei; | ||
| } | ||
| const matchingIndex = optimizedData.findIndex( |
Member
There was a problem hiding this comment.
This is a bit messy. You should use reduce for this use case. Very useful to transform an array into a map (de duping keys in the process). Then you can get an array back from the map by just getting all the entries
gregfromstl
reviewed
Nov 1, 2024
kien-ngo
force-pushed
the
kien/improve-erc20-transferBatch
branch
from
017315e to
5ed2983
Compare
kien-ngo
force-pushed
the
kien/improve-erc20-transferBatch
branch
from
5ed2983 to
875ede4
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
force-pushed
the
kien/improve-erc20-transferBatch
branch
from
875ede4 to
f1c98a1
Compare
gregfromstl
approved these changes
Nov 4, 2024
kien-ngo
force-pushed
the
kien/improve-erc20-transferBatch
branch
from
f1c98a1 to
634e062
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5256 +/- ##
==========================================
+ Coverage 45.44% 45.47% +0.02%
==========================================
Files 1067 1067
Lines 55459 55486 +27
Branches 4009 4013 +4
==========================================
+ Hits 25206 25230 +24
- Misses 29562 29565 +3
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on optimizing the `transferBatch` functionality for ERC20 tokens by improving the way transfers are processed, allowing for batching of transfers to the same recipient, and enhancing the test coverage for these changes.
### Detailed summary
- Added `optimizeTransferContent` function to group transfers by recipient.
- Refactored `transferBatch` to use optimized transfer content.
- Updated tests to verify optimized transfers and ensure correctness.
- Increased token minting in tests from 100 to 200 tokens.
- Enhanced test cases to validate optimized transfer behavior.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/improve-erc20-transferBatch
branch
from
634e062 to
f98059c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on optimizing the
transferBatchfunctionality for ERC20 token transfers by implementing a new method to group and consolidate transfer records, reducing redundant transactions.Detailed summary
optimizeTransferContentfunction to consolidate transfers with the same recipient.transferBatchto utilize optimized transfer data.